Re: [PATCH tip/tracing/markers] markers: simplify marker_set_format()
From: Lai Jiangshan
Date: Mon Oct 20 2008 - 04:50:34 EST
Mathieu Desnoyers wrote:
> * Lai Jiangshan (laijs@xxxxxxxxxxxxxx) wrote:
>> current marker_set_format() is complex this patch simplify it,
>> and decrease the overhead of marker_update_probes().
> Yep, I think I did put the format string after the name \0, which was
> rather tricky. I agree that such change makes the code more readable at
> the expense of doing 2 allocations per marker rather than one, but
> readability might be a good thing here.
> Thanks !
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>
Do you have any objections against these patches?
[PATCH tip/tracing/markers] markers: simplify marker_set_format()
[PATCH tip/tracing/markers] markers: remove exported symbol marker_probe_cb_noarg()
[PATCH tip/tracing/markers] markers: let marker_table be close to its comments
My new patch are being made on the top of these patches.
[PATCH tip/tracing/markers] markers: new callbacks manager
new patch remove a lot code and speed up critical region
and not change any APIs.
new patch change too much code, so I have to wait until all known
patches(which can be applied) have been applied.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/