Re: Re: [PATCH] Breaks the redundant loop in kernel/marker.c
From: Ingo Molnar
Date: Mon Oct 20 2008 - 03:25:48 EST
* Zhaolei <zhaolei@xxxxxxxxxxxxxx> wrote:
> Ingo Molnar wrote:
> > hm, could you describe the necessity of this patch some more? This has
> > the change to change behavior, which might even be a bugfix: is there
> > any chance that the closure-loop in the e->ptype != NULL branch does not
> > exit? Before your patch we'd continue the iteration - which _probably_
> > does not lead to any more matches (e->name is supposed to be unique).
> Because e->name is unique in list, we don't need to continue the iteration
> after matched.
> This is a cleanup.
ok - it's useful to point this out in the changelog. You can use the
"Impact:" header we started using recently:
Impact: cleanup, no functionality changed
See for example this upstream commit:
| commit 07454bfff151d2465ada809bbaddf3548cc1097c
| Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
| Date: Sat Oct 4 10:51:07 2008 +0200
| clockevents: check broadcast tick device not the clock events device
| Impact: jiffies increment too fast.
Mathieu, any objections against the patch?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/