Re: [PATCH] x86: Add clflush before monitor for Intel 7400 series

[H. Peter Anvin]

Pallipadi, Venkatesh wrote:
> hpa,
>
> Do you still have reservations about this being expensive.
> Note that this is only done when a CPU is about to go idle and
> The cost of clflush itself will be minimal compared to idle
> entry + idle exit latency.

I guess I'm a bit confused about the tradeoff of CLFLUSH versus simply 
disabling MWAIT.  This is a relatively recent processor and so 
optimizing matters (if this was a P4 I would be more worried about what 
has least impact on the kernel as a whole.)

Entry and exit latency do matter (specifically, exit latency matters for 
longer waits and the combined entry+exit latency matters for short waits.)

On the other hand, perhaps what we need to do is to get the fix in and 
worry about performance later.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/