Re: [PATCH] Add Dallas DS1390 RTC chip

[Mark Jackson]

David Brownell wrote:
> On Friday 17 October 2008, Mark Jackson wrote:
> > > > +    /* Can tx_buf and rx_buf be equal? The doc in spi.h is not sure... */
> > > > +    xfer.tx_buf = chip->tx_buf;
> > > > +    xfer.rx_buf = chip->rx_buf;
> > >  you use the same buffer a few functions below. either
> > >  one way or the other. please investigate with the spi subsystem maintainer.
> > David,
> >
> > Just to double check (as per Alessandro's suggestion), is this okay use of the 
> > spi buffers ?
>
> Yes.  That comment deserves to be updated.
>
> SPI does bi-directional I/O, and the underlying controller
> should be able to just replace the contents of a buffer
> with a spi_transfer that uses the same rx and tx buffers.

Excellent.  Thanks for the confirmation.

Regards
Mark
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/