Re: [PATCH] init: Properly placing noinline keyword.

[AmÃrico Wang]

On Fri, Oct 17, 2008 at 09:10:07PM +0600, Rakib Mullick wrote:
>On 10/17/08, AmÃrico Wang <xiyou.wangcong@xxxxxxxxx> wrote:
>> On Fri, Oct 17, 2008 at 08:17:33PM +0600, Rakib Mullick wrote:
>>  >On 10/17/08, Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
>>  >> On Fri, Oct 17, 2008 at 07:05:32PM +0600, Rakib Mullick wrote:
>>  >>  > Here, noinline keyword should be placed between storage class and type.
>>  >>
>>  >>
>>  >> Why?
>>  >Because, scripts/checkpatch.pl warned with following warning:
>>  >     ERROR: inline keyword should sit between storage class and type
>>
>>
>> Well, 'noinline' is different from 'inline'.
>>
>>  'noinline' is defined as:
>>
>>  #define  noinline                       __attribute__((noinline))
>>
>>  in include/linux/compiler-gcc.h. But 'inline' is a _keyword_ defined
>>  by C standard. If checkpatch.pl complains about 'noinline', you should
>>  fix checkpatch.pl. :)
>Thanks, for explanation. But isn't it nice to place it between storage
>class and type ?

I don't think so, I don't know why checkpatch.pl prefers that style.
I think probably only because that is more readable?

Anyway, gcc attribute is another different thing.

-- 
"Sometimes the only way to stay sane is to go a little crazy."

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/