Re: [PATCH] Enable console on PCI serial devices

From: n0ano
Date: Fri Oct 17 2008 - 13:07:04 EST


On Fri, Oct 17, 2008 at 10:39:52AM -0600, Bjorn Helgaas wrote:
>...
> Here's another possibility, maybe too wordy, but maybe more straightforward:
>
> + uart[8250],mmio,<addr>[,options[,clock]]
>
> + "clock" is the frequency of the crystal driving
> + the UART clock (typically sixteen times the
> + fastest baud rate supported by the UART).
>
> + port->uartclk = simple_strtoul(options, NULL, 0);
>

We could do that but now the `clock' value becomes a very large
number that is very magic. Putting in the highest baud rate seems
to make more sense than some magic number.

--
Don Dugger
"Censeo Toto nos in Kansa esse decisse." - D. Gale
n0ano@xxxxxxxxx
Ph: 303/443-3786
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/