Re: [PATCH] include/linux/mca-legacy.h: Fix the warning

[Adrian Bunk]

On Fri, Oct 17, 2008 at 09:20:44PM +0800, Jianjun Kong wrote:
> Fix the warning of annotation.
> 
>   CC    drivers/mca/mca-legacy.o
>   In file included from drivers/mca/mca-legacy.c:31:
>   include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy -
>   please move your driver to the new sysfs api"
>   In file included from drivers/mca/mca-legacy.c:31:
>   include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy -
>   please move your driver to the new sysfs api"
> 
> Signed-off-by: Jianjun Kong <jianjun@xxxxxxxxx>
> ---
>  include/linux/mca-legacy.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/mca-legacy.h b/include/linux/mca-legacy.h
> index 7a3aea8..e349f2b 100644
> --- a/include/linux/mca-legacy.h
> +++ b/include/linux/mca-legacy.h
> @@ -9,7 +9,7 @@
>  
>  #include <linux/mca.h>
>  
> -#warning "MCA legacy - please move your driver to the new sysfs api"
> +/* warning "MCA legacy - please move your driver to the new sysfs api" */
>...

NAK

If you want to get rid of the warning fix the drivers still using the 
obsolete API.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/