Re: [PATCH] Fix debugfs_create_dir's error checking method for sound/soc/

From: Mark Brown
Date: Fri Oct 17 2008 - 09:23:56 EST

On Fri, Oct 17, 2008 at 09:04:55PM +0800, Zhaolei wrote:

> debugfs_create_dir() returns NULL if an error occurs, returns -ENODEV
> when debugfs is not enabled in the kernel.


> asoc_debugfs = debugfs_create_dir("asoc", NULL);
> - if (!IS_ERR(asoc_debugfs))
> + if (!IS_ERR(asoc_debugfs) && asoc_debugfs)
> debugfs_create_u32("dapm_pop_time", 0744, asoc_debugfs,
> &pop_time);

Hrmpf. This looks like something that should be fixed in debugfs -
using both error reporting strategies is rather unhelpful and we're
actually loosing information in the case where debugfs is built. I'll
send a patch and see what people thing.

Still in the meantime,

Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at