Re: [PATCH] Fix broken debug output reserve_region_with_split()

From: H. Peter Anvin
Date: Fri Oct 17 2008 - 02:41:53 EST


Benjamin Herrenschmidt wrote:

With that patch, it will use just as many digits as necessary to display
a given number. The question I'm asking in the comments is whether we
want to instead use fixed digits with zero padding, and in that case,
do we want a hook or something for archs to decide how many digits
for IO vs. memory.


Yes, and yes.

We want to pad to keep people from mistaking, say, c000000 from c0000000. At least on x86, it also acts as a visual cue for the type of resource space, as people are used to seeing I/O ports as 16-bit numbers with four hexdigits, and 8- or 16-hexdigit numbers for memory addresses.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/