Re: [PATCH] SYSFS: Fix return values for sysdev_store_{ulong,int}

[Andi Kleen]

On Thu, Oct 16, 2008 at 01:35:30PM -0700, Andrew Morton wrote:
> On Mon, 13 Oct 2008 12:03:03 +0200
> Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> 
> > SYSFS: Fix return values for sysdev_store_{ulong,int}
> > 
> > Always return the full size instead of the consumed
> > length of the string in sysdev_store_{ulong,int}
> > 
> > This avoids EINVAL errors in some echo versions.
> 
> That sounds fairly serious.  Is this a regression or are those versions
> of echo really ancient, or...?

It's a regression, but it currently only affects the mce sysfs files,
which are the only ones using it. Also the EINVAL is more a cosmetic
issue because the first write will already change the value successfully,
only the second one will fail but not change anything.

-Andi

-- 
ak@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/