Re: [PATCH] Fix broken debug output reserve_region_with_split()
From: Linus Torvalds
Date: Thu Oct 16 2008 - 23:49:58 EST
On Fri, 17 Oct 2008, Benjamin Herrenschmidt wrote:
> Ok, I'll wait for more comments before a respin to :-) I'm mostly
> wondering whether to use fixed sized format rather than the current
> variable size (and pad with zeros).
Sadly, I think that gcc warns if we were to support %08pR, so we can't
pass down flags.
That said, I don't much like SPECIAL in the flags. We never do that thing.
Doing a git grep for some range printouts, we tend to do things like
[%x - %x]
[%016lx - %016lx]
But using "0x%llx" or "%#llx" is very rare. It happens (notably
drivers/pci/setup-res.c), but it's not common.
But it would be kind of nice to be able to do extended flags. Maybe we
could do it with
and the 04 would be parsed as flags, the same way we do %04x. And then if
you want the 0x, you can use %p#08R..
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/