Re: [stable] [patch] gpiolib: fix oops in gpio_get_value_cansleep()

[Greg KH]

On Thu, Oct 16, 2008 at 05:54:49PM -0700, Andrew Morton wrote:
> On Thu, 16 Oct 2008 17:44:33 -0700 David Brownell <david-b@xxxxxxxxxxx> wrote:
> 
> > On Thursday 16 October 2008, Andrew Morton wrote:
> > > > From: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> > > > 
> > > > We can get the following oops from gpio_get_value_cansleep()
> > > > when a GPIO controller doesn't provide a get() callback:
> > > 
> > > We can, but do we? ;)
> > 
> > I think it's unlikely without the sysfs interface.
> > 
> > 
> > > iow: is this needed in any -stable release?
> > 
> > The bug has been there since 2.6.25 but nobody else seems
> > to have reported it.  Is the general policy to fix all
> > oopses that *could* appear?  I'd send it for 2.6.27-stable,
> > since that's got the sysfs hooks.  And older kernels if
> > bug likelihood isn't a major concern.
> 
> OK.  2.6.27 definitely (major distros are basing on that).
> 
> As for earlier kernels: I'd say so.  An oops is farily serious. 
> Although an oops in a sysfs handler tends to be fairly tame, as the
> code usually doesn't hold locks or many allocated resources.
> 
> Anyway - making decisions like this is why we pay stable@xxxxxxxxxx the
> big bucks :)

"Pay"?  We get paid for this in something becides a full inbox?

I'm not holding my breath :)

Send us the git commit id when it's in Linus's tree and we'll see what
is needed to backport this or not.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/