Re: [PATCH 2/2] cciss: fix regression in procfs display fw version,obsoletes previous patch 2 of 2

[Alexey Dobriyan]

On Thu, Oct 16, 2008 at 10:56:58PM +0000, Miller, Mike (OS Dev) wrote:
> > > > +     return_code = sendcmd_withirq(CISS_INQUIRY, i, inq_buff,
> > > > > +             sizeof(InquiryData_struct), 0, 0 ,0, TYPE_CMD);
> > > > > +     if (return_code == IO_OK) {
> > > > > +             hba[i]->firm_ver[0] = inq_buff->data_byte[32];
> > > > > +             hba[i]->firm_ver[1] = inq_buff->data_byte[33];
> > > > > +             hba[i]->firm_ver[2] = inq_buff->data_byte[34];
> > > > > +             hba[i]->firm_ver[3] = inq_buff->data_byte[35];
> > > > > +     } else {         /* send command failed */
> > > > > +             printk(KERN_WARNING "cciss: unable to
> > > > determine firmware"
> > > > > +                     " version of controller\n");
> > > > > +     }
> > > > > +
> > > > >       cciss_procinit(i);
> > > > >
> > > > >       hba[i]->cciss_max_sectors = 2048;
> > >
> > > Sorry, in too much of a hurry. I'll fix (again).
> >
> > And inq_buff is leaked, if I'm not missing simething.
> >
> Sorry, Alexy, I can't see the leak. Is it in the failure case?

Where "inq_buff" is freed?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/