Re: [PATCH 1/7] powerpc and sparc: introduce dev_archdata node accessors

From: Grant Likely
Date: Thu Oct 16 2008 - 19:03:13 EST


On Thu, Oct 16, 2008 at 4:36 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx>
> Date: Thu, 16 Oct 2008 21:12:51 +0400
>
>> The name of the device_node field differ across the platforms, so we
>> have to implement inlined accessors. This is needed to avoid ugly
>> #ifdef in the generic code.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx>
>
> I'm happy to just change this member name on sparc to match
> powerpc's choice.
>
> That being said, this abstraction still has value and I'd
> like to let you merge this now and make forward progress
> so:
>
> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>

I agree;

Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>



--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/