Re: [PATCH 4/5] mm: rework do_pages_move() to work on page_sizedchunks

[Christoph Lameter]

Brice Goglin wrote:

> +	err = -ENOMEM;
> +	pm = kmalloc(PAGE_SIZE, GFP_KERNEL);
> +	if (!pm)

ok.... But if you need a page sized chunk then you can also do
	get_zeroed_page(GFP_KERNEL). Why bother the slab allocator for page 		sized
allocations?


> +	chunk_nr_pages = PAGE_SIZE/sizeof(struct page_to_node) - 1;

Blanks missing.



> +		/* fill the chunk pm with addrs and nodes from user-space */
> +		for (j = 0; j < chunk_nr_pages; j++) {

j? So the chunk_start used to be i?


Acked-by: Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/