Re: [PATCH] Add support for Dallas DS28CM00 Unique ID chip

[Andrew Morton]

On Tue, 07 Oct 2008 14:09:59 +0100
Mark Jackson <mpfj@xxxxxxxxxx> wrote:

> This patch adds support for the (I2C based) DS28CM00 ID chip.

Please run scritps/checkpatch.pl across the diff and consider the
various things which it reports.  Many of them are minor layout issues.
The lack of printk facility levels is a should-fix thing.


>        printk("adding ds28cm00 driver !!\n");

Remove the " !!" :)

Please also cc i2c@xxxxxxxxxxxxxx on version 2.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/