Re: [PATCH 72/80] tty: fix up gigaset a bit

[Tilman Schmidt]

Am 13.10.2008 11:44 schrieb Alan Cox:
> From: Alan Cox <alan@xxxxxxxxxx>
> 
> Stephen's fixes reminded me that gigaset is still rather broken so fix it up
> a bit
> 
> Signed-off-by: Alan Cox <alan@xxxxxxxxxx>

Acked-by: Tilman Schmidt <tilman@xxxxxxx>

Thanks, Alan, for these improvements.
I'm now looking into the FIXME comments you added.

> @@ -571,6 +571,7 @@ gigaset_tty_close(struct tty_struct *tty)
>  	}
>  
>  	/* prevent other callers from entering ldisc methods */
> +	/* FIXME: should use the tty state flags */
>  	tty->disc_data = NULL;
>  
>  	if (!cs->hw.ser)

Do you know of an example line discipline that has got this right?
My model for this code was drivers/net/ppp_async.c but now it seems
that this was not as exemplary as I had hoped.

> @@ -680,6 +675,8 @@ gigaset_tty_ioctl(struct tty_struct *tty, struct file *file,
>  /*
>   * Poll on the tty.
>   * Unused, always return zero.
> + *
> + * FIXME: should probably return an exception - especially on hangup
>   */
>  static unsigned int
>  gigaset_tty_poll(struct tty_struct *tty, struct file *file, poll_table *wait)

Looking around, I see that many LDs don't even provide a poll method.
So I'm thinking of just dropping this one. Would that be ok?

Thanks,
Tilman

-- 
Tilman Schmidt                    E-Mail: tilman@xxxxxxx
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
UngeÃffnet mindestens haltbar bis: (siehe RÃckseite)

Attachment: signature.asc
Description: OpenPGP digital signature