Re: GIT head no longer boots on x86-64

From: H. Peter Anvin
Date: Thu Oct 16 2008 - 06:32:16 EST


Linus Torvalds wrote:

Oh, btw. This patch is *totally* untested. I don't even enable modules. So if it doesn't compile, it isn't perfect. But while it may not _work_, at least it's not _ugly_.

(Quite frankly, I think an even more correct fix is to rename the whole "vmalloc_to_page()" function, since it's clearly used for other things than vmalloc. Maybe "kernel_virtual_to_page()". Whatever. This is trying to be minimal without being totally disgusting).


I have verified that this patch fixes the problem, at least in my test rig, and has queued it up for tip:x86/urgent. It should be in the next pull request.

Note that this bug only bites when CONFIG_DEBUG_VIRTUAL=y and we're running an SMP kernel on UP. Not that that is any excuse.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/