Re: [PATCH] sparc64: Annotate pointers in PeeCeeI.c

From: David Miller
Date: Wed Oct 15 2008 - 20:24:27 EST


From: Harvey Harrison <harvey.harrison@xxxxxxxxx>
Date: Wed, 15 Oct 2008 17:15:19 -0700

> This has no functional changes, but annotates the code to make
> the endianness more clear. In addition, removes some of the only
> users of cpu_to_le[16|32]p in the kernel.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>

Remind me what the problem is with cpu_to_{le,be}*()?

The interface names define a direction, which in this case is
"CPU endianness to BE/LE endianness". And that is exactly
what is happening in the out*() routines.

This aids comprehension of the code and is quite useful IMHO.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/