Re: [PATCH] SiS55x, another x86 CPU

From: Hans Schou
Date: Wed Oct 15 2008 - 18:37:45 EST


On Wed, 15 Oct 2008, Geert Uytterhoeven wrote:

On Wed, 15 Oct 2008, Andi Kleen wrote:
If any CR/LF in your file you must have added them yourself.

There were definitely CR/LFs in the patch attachment you sent.
And no my mailer doesn't add them.

Interesting. I didn't see any CR/LFs neither, after exporting the
attachment to a file (I'm using pine).

As far as I could see, Pine does this:

1. If file has not extension like: .zip .jpg .exe, see it as ASCII
2. Add CR/LF to the file
3. Encode file as base64

On reception of the file:

1. Decode file as specified (in this case base64)
2. If it looks like a text file, convert CR/LF to LF.

However, when doing a base64 decode on the raw attachment data, the
CR/LFs did pop up.

I think time is up for getting rid of Pine and there stupid license. I'll check if "nail" can handle attachment correctly.

/hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/