Re: [PATCH 1/5] HDQ Driver for OMAP2430/3430

From: Andrew Morton
Date: Tue Oct 14 2008 - 10:34:38 EST


> On Tue, 14 Oct 2008 17:42:49 +0400 Evgeniy Polyakov <johnpol@xxxxxxxxxxx> wrote:
> Hi.
>
> On Tue, Oct 14, 2008 at 05:50:02AM -0700, Andrew Morton (akpm@xxxxxxxxxxxxxxxxxxxx) wrote:
> > I think it's reasonable to permit the driver's operations to be interrupted
> > in this manner. It's done in quite a few other places. But the problem is
> > actually *testing* it.
>
> Why not just skipping the waiting and returning error pretending user
> really sent a signal?

Better than nothing, but because signal_pending() isn't actually true,
upper layers wil behave differently.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/