[PATCH] serial: fix serial port lock init

From: Ingo Molnar
Date: Tue Oct 14 2008 - 06:23:35 EST



> [ 31.099528] BUG: spinlock bad magic on CPU#1, agetty/2608

the patch below fixes this. There's another incarnation of the bug that
i bisected today, a spontaneous reboot crash with certain configs:

| b70ac7718579b5cbf3bdd74fd01132d1c91596f4 is first bad commit
| commit b70ac7718579b5cbf3bdd74fd01132d1c91596f4
| Author: David Miller <davem@xxxxxxxxxxxxx>
| Date: Mon Oct 13 10:36:31 2008 +0100
|
| serial: allow 8250 to be used on sparc

# bad: [e7f2f991] Merge phase #5 (misc) of git://git.kernel.org/pub/
# good: [3fa8749e] Linux 2.6.27
# good: [4dd9ec49] Merge git://git.kernel.org/pub/scm/linux/kernel/gi
# good: [5c3c4d9b] Merge git://git.kernel.org/pub/scm/linux/kernel/gi
# good: [1a2217a9] Merge git://git.kernel.org/pub/scm/linux/kernel/gi
# good: [cf81978d] i386: convert hardware exception 15 to an interrup
# good: [c00193f9] Merge branches 'oprofile-v2' and 'timers/hpet' int
# bad: [8f520021] tty: Termios locking - sort out real_tty confusion
# good: [f1ddfd95] ip2: init/deinit cleanup
# bad: [b70ac771] serial: allow 8250 to be used on sparc
# good: [9bde10a4] serial-make-uart_ports-ioport-unsigned-long-fix
# good: [43b11d33] ftdi: A few errors are err() that should be debug
# good: [b5d674ab] 8250: remove a few inlines of dubious value

( but it's the same basic problem: we lost the lock init sequence when a
patch was removed from the middle. )

Ingo

----------------->