Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

From: David Miller
Date: Mon Oct 13 2008 - 21:40:55 EST


From: "Guo-Fu Tseng" <cooldavid@xxxxxxxxxxxxx>
Date: Tue, 14 Oct 2008 03:28:14 +0800

> But since <net/ip6_checksum.h> compensate the lack of
> `csum_ipv6_magic` function defined in <asm/checksum.h>
> of some architecture, should <net/ip6_checksum.h> be
> included in <net/checksum.h> as well?

No, the standard convention is that if you need to call this
ipv6 checksumming routine you include net/ip6_checksum.h
From: "Guo-Fu Tseng" <cooldavid@xxxxxxxxxxxxx>
Date: Tue, 14 Oct 2008 03:28:14 +0800

> BTW, if there is a patch against jme driver which I maintain,
> and I just simply agree with it, should I silently noticed that
> and let someone like Jeff or David to review/apply it,
> or should I reply an ack of it?

You can ACK it and I usually apply patches like this directly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/