Re: [PATCH] x86: split e820 reserved entries record to late v4 -fix v7

From: H. Peter Anvin
Date: Mon Oct 13 2008 - 17:54:54 EST


Linus Torvalds wrote:

Or we could do what Andrew suggested some time ago, and extend %p to do resource printing, like %pS and %pF.

TOTALLY UNTESTED! But something like this might allow

printk(KERN_DEBUG " reserve_region: (%s) %pR\n"
res->name, res);

and if I did things right it should print

reserve_region: (name) [xx-xx]

and maybe it's worth it. We certainly do seem to have a fair number of those irritating casts for resource printouts.


There is certainly a lot to be said for this. Using higher-level interfaces keeps formatting consistent and gives us one place to change things if desired.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/