Re: [BUILD_FAILURE] 2.6.27-git2 - allyesconfig on powerpc selectsCONFIG_INTEL_IOATDMA=y

[Brice Goglin]

Adrian Bunk wrote:
> On Mon, Oct 13, 2008 at 03:45:59PM +0530, Kamalesh Babulal wrote:
>   
>> Hi,
>>
>>    2.6.27-git2 kernel build fails, while building the kernel with
>> allyesconfig option. The allyesconfig selects CONFIG_INTEL_IOATDMA=y
>>
>> CC   drivers/dma/ioat_dca.o
>> drivers/dma/ioat_dca.c: In function ÃÂÂdca_enabled_in_biosÃÂÂ:
>> drivers/dma/ioat_dca.c:81: error: implicit declaration of function ÃÂÂcpuid_eaxÃÂÂ
>> drivers/dma/ioat_dca.c: In function ÃÂÂsystem_has_dca_enabledÃÂÂ:
>> drivers/dma/ioat_dca.c:91: error: implicit declaration of function ÃÂÂboot_cpu_hasÃÂÂ
>> drivers/dma/ioat_dca.c:91: error: ÃÂÂX86_FEATURE_DCAÃÂÂ undeclared (first use in this function)
>> drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once
>> drivers/dma/ioat_dca.c:91: error: for each function it appears in.)
>> drivers/dma/ioat_dca.c: In function ÃÂÂioat_dca_get_tagÃÂÂ:
>> drivers/dma/ioat_dca.c:190: error: implicit declaration of function ÃÂÂcpu_physical_idÃÂÂ
>> make[2]: *** [drivers/dma/ioat_dca.o] Error 1
>> make[1]: *** [drivers/dma] Error 2
>> make: *** [drivers] Error 2
>> ...
>>     
>
> Thanks for the report, the MYRI10GE and IXGBE commits that introduced 
> the select's are really broken.
>
> For fixing it I need to know the intended semantics.
>
> Brian, Jesse, is it OK to limit the drivers to m with 
> CONFIG_INTEL_IOATDMA=m ?
>   

I think I would rather drop DCA from myri10ge if IOATDMA=m while
myri10ge=y. What's the simplest way to do so?

When Jesse told me to commit this in myri10ge, I thought it would be
nice to have DCA work the same than NETDMA/DMAengine does: you can have
NETDMA enabled without IOATDMA (either not built at all, or just not
loaded). You just don't get any DMA channel when you ask for one. Why
not do the same for DCA? There could be some generic DCA layer that can
be built all the time and returns DCA resources only if IOATDMA is
loaded/built ?

Brice

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/