Re: acpi-test tree on eeepc: EC error message on second resume

From: Zhao Yakui
Date: Sun Oct 12 2008 - 21:32:17 EST


On Sun, 2008-10-12 at 23:23 +0400, Alexey Starikovskiy wrote:
> +static int ec_wait_ibf0(struct acpi_ec *ec)
> +{
> + unsigned long delay = jiffies +
> msecs_to_jiffies(ACPI_EC_DELAY);
> + while (time_before(jiffies, delay)) {
> + if (wait_event_timeout(ec->wait, ec_check_ibf0(ec),
> + msecs_to_jiffies(1)))
> + return 0;
Please add the bogus timeout check.
best regards.
Yakui
> + }
> + return -ETIME;
> +}
> +

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/