Re: [PATCH 2/8 2.6.28] cxgb3 - Allocate multiqueues at init time

From: David Miller
Date: Wed Oct 08 2008 - 20:42:44 EST


From: Divy Le Ray <divy@xxxxxxxxxxx>
Date: Wed, 08 Oct 2008 17:34:02 -0700

> Allocate a queue set per core, up to the maximum of available qsets.
> Share the queue sets on multi port adapters.
> Rename MSI-X interrupt vectors ethX-N, N being the queue set number.
>
> Signed-off-by: Divy Le Ray <divy@xxxxxxxxxxx>

Applied, but...

This "num processors" logic and policy belongs in some generic place.
Perhaps "num_possible_cpus()" is more appropriate, who knows right?

Otherwise every stinking driver is going to implement this in
their own way and use their own policy, and from a user experience
perspective that totally sucks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/