Re: [PATCH, RFC] shmat: introduce flag SHM_MAP_HINT

[Kirill A. Shutemov]

On Tue, Oct 07, 2008 at 08:08:19PM +0900, KOSAKI Motohiro wrote:
> > It allows interpret attach address as a hint, not as exact address.
> > 
> > Signed-off-by: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>
> > Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > ---
> >  include/linux/shm.h |    1 +
> >  ipc/shm.c           |    4 ++--
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/shm.h b/include/linux/shm.h
> > index eca6235..2a637b8 100644
> > --- a/include/linux/shm.h
> > +++ b/include/linux/shm.h
> > @@ -55,6 +55,7 @@ struct shmid_ds {
> >  #define	SHM_RND		020000	/* round attach address to SHMLBA boundary */
> >  #define	SHM_REMAP	040000	/* take-over region on attach */
> >  #define	SHM_EXEC	0100000	/* execution access */
> > +#define	SHM_MAP_HINT	0200000	/* interpret attach address as a hint */
> 
> hmm..
> Honestly, I don't like that qemu specific feature insert into shmem core.
> At least, this patch is too few comments.
> Therefore, an develpper can't understand why SHM_MAP_HINT exist.
> 
> I think this patch description is too short and too poor.
> I don't like increasing mysterious interface.

Sorry for it. I'll fix it in next patch version.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

Attachment: signature.asc
Description: Digital signature