Re: [PATCH] x86: SB450: skip IRQ0 override if it is not routed toINT2 of IOAPIC

[Ingo Molnar]

* Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:

> On Tue, Oct 07, 2008 at 05:41:32AM +0200, Ingo Molnar wrote:
> > 
> > * Andreas Herrmann <andreas.herrmann3@xxxxxxx> wrote:
> > 
> > > So, let's work around BIOS bugs in Linux then ...
> > > 
> > > Following patch is almost untested -- especially I didn't get my hands 
> > > on one of the HP Laptops with broken DSDT.
> > [...]
> > > On some HP nx6... laptops (e.g. nx6325) BIOS reports an IRQ0 override 
> > > but the SB450 chipset is configured such that timer interrupts goe to 
> > > INT0 of IOAPIC.
> > > 
> > > Check IRQ0 routing and if it is routed to INT0 of IOAPIC skip the 
> > > timer override.
> > > 
> > > Signed-off-by: Andreas Herrmann <andreas.herrmann3@xxxxxxx>
> > >
> > > ---
> > >  arch/x86/kernel/early-quirks.c |   48 ++++++++++++++++++++++++++++++++++++++++
> > >  1 files changed, 48 insertions(+), 0 deletions(-)
> > 
> > very nice, thanks Andreas! Applied to tip/x86/quirks. This PCI ID based 
> > quirk should be more complete than DMI matches.
> > 
> 
> You may add 'Tested by: Dmitry Torokhov <dtor@xxxxxxx> on nx6115'
> It works fine here with Andreas patch applied and with Rafael's patch
> dropped.
>
> Thanks Andreas!

ok, added your Tested-by to the changelog, thanks.

I also applied the patch below to deprioritize the DMI quirks for this 
problem (without actually removing them, yet). Could you please check 
whether latest tip/master:

  http://people.redhat.com/mingo/tip.git/README

boots fine out of box and that the WARN() does not trigger?

	Ingo

--------------->