Re: [PATCH 36/76] tty: Make get_current_tty use a kref

From: Alan Cox
Date: Mon Oct 06 2008 - 06:57:18 EST


On Mon, Oct 06, 2008 at 12:35:40PM +0200, Louis Rilling wrote:
> > tty = get_current_tty();
> > if (!tty || tty->driver->major != IBM_TTY3270_MAJOR) {
> > - mutex_unlock(&tty_mutex);
> > + tty_kref_put(tty);
>
> Should'nt mutex_unlock() be kept?

Yes.. although it gets fixed later but I will fix that as it will keep the
code bisectable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/