Re: [PATCH 1/1] Add c2 port support.

[Greg KH]

On Fri, Oct 03, 2008 at 04:36:29PM +0200, Rodolfo Giometti wrote:
> C2port implements a two wire serial communication protocol (bit
> banging) designed to enable in-system programming, debugging, and
> boundary-scan testing on low pin-count Silicon Labs devices.
> 
> Currently this code supports only flash programming through sysfs
> interface but extensions shoud be easy to add.
> 
> Signed-off-by: Rodolfo Giometti <giometti@xxxxxxxx>
> ---
>  drivers/misc/Kconfig       |   13 +
>  drivers/misc/Makefile      |    1 +
>  drivers/misc/c2port_core.c |  996 ++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/c2port.h     |   65 +++

Why does this file have to be in include/linux?  I don't think this
exports any structures to userspace, and no other code calls this
driver, so it should all fit into the .c file just fine.

Also, please create the needed Documentation/ABI/ files for these new
sysfs entries, describing how they are used, and what the format of them
are.

Is there any way to detect automatically if this hardware is present in
the system or not?

Otherwise, how will it be loaded by a distro automatically?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/