RE: [regression] Latest git has WARN_ON storm with e1000e driver

[Brandeburg, Jesse]

Linus Torvalds wrote:
> So this whole bug is actually because that debug test is just
> _broken_. It shouldn't be WARN_ON(preempt_count()), it should be
> 'might_sleep()', which does it right.
> 
> The right thing to check is "in_atomic() || irqs_disabled()".

okay, do you want me to post a patch?  I think Thomas is probably
offline due to fridaynightitis.  Change the code to:?

WARN_ON(in_atomic() || irqs_disabled);
 
> Duh. That was wasted effort for a buggy test.

Apologies for not catching it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/