Re: [PATCH 2/2] x86: mtrr_cleanup try gran_size to less than 1M

[H. Peter Anvin]

Ingo Molnar wrote:
> > +++ arch/x86/kernel/cpu/mtrr/if.c     2008-10-03 00:22:34.000000000 +0200
> > @@ -16,7 +16,7 @@
> >  static const char *const mtrr_strings[MTRR_NUM_TYPES] =
> >  {
> >      "uncachable",               /* 0 */
> > -    "write-combining",          /* 1 */
> > +    "write-combine",            /* 1 */
>
> hm, maybe this bit could confuse versions of Xorg that modifies 
> /proc/mtrr - i.e. this could be part of the ABI towards user-space. 
> We'll see.

By the way, this is just plain wrong; the cachability name is "Write 
Combining (WC)" not "write-combine".

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/