Re: mmotm 2008-10-02-16-17 uploaded

From: Andrew Morton
Date: Thu Oct 02 2008 - 20:46:15 EST


On Thu, 2 Oct 2008 17:17:16 -0700 (PDT)
"Randy.Dunlap" <rdunlap@xxxxxxxxxxxx> wrote:

> I'll work on some patches for them as time permits...
> or you could drop them, push them back to their submitters...

That tree's such a dog's breakfast that I haven't even tried to compile
it, and I hope not to do so until Stephen returns and puts it all back
together again.

I should have asked Stephen to try to find someone to keep it all
ticking over while he is away.

This one:

build-r9491.out:/home/rdunlap/linsrc/mmotm-2008-1002-1617/include/linux/stacktrace.h:13: warning:
'struct task_struct' declared inside parameter list

is an honest-to-goodness, should-be-fixed-yesterday upstream bug.


From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

include/linux/stacktrace.h:13: warning:
'struct task_struct' declared inside parameter list

Reported-by: "Randy.Dunlap" <rdunlap@xxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxx>
Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Cc: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

include/linux/stacktrace.h | 2 ++
1 file changed, 2 insertions(+)

diff -puN include/linux/stacktrace.h~include-linux-stacktraceh-declare-struct-task_struct include/linux/stacktrace.h
--- a/include/linux/stacktrace.h~include-linux-stacktraceh-declare-struct-task_struct
+++ a/include/linux/stacktrace.h
@@ -1,6 +1,8 @@
#ifndef __LINUX_STACKTRACE_H
#define __LINUX_STACKTRACE_H

+struct task_struct;
+
#ifdef CONFIG_STACKTRACE
struct stack_trace {
unsigned int nr_entries, max_entries;
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/