Re: [PATCH] rtc: fix kernel panic on second use of SIGIO nofitication

[David Brownell]

On Thursday 02 October 2008, Alessandro Zummo wrote:
> On Thu, 2 Oct 2008 14:49:41 -0700
> Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Sun, 14 Sep 2008 20:11:27 +0200
> > Marcin Slusarz <marcin.slusarz@xxxxxxxxx> wrote:
> > 
> > > When user space uses SIGIO notification and forgets to disable it before
> > > closing file descriptor, rtc->async_queue contains stale pointer to struct
> > > file. When user space enables again SIGIO notification in different process,
> > > kernel dereferences this (poisoned) pointer and crashes.
> > > 
> > > So disable SIGIO notification on close.
> > > 
> > 
> > David, Alessandro: can we please have a review-n-ack of this one for
> > 2.6.27 and earlier?  
> > 
> > Thanks.
> > 
> > From: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
> > 
> > When userspace uses SIGIO notification and forgets to disable it before
> > closing file descriptor, rtc->async_queue contains stale pointer to struct
> > file.  When user space enables again SIGIO notification in different
> > process, kernel dereferences this (poisoned) pointer and crashes.
> > 
> > So disable SIGIO notification on close.
> 
>  [...]
> > 
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
> > Cc: Alessandro Zummo <alessandro.zummo@xxxxxxxxxxxx>
> > Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> > Cc: <stable@xxxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> 
>  
>  Acked-by: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>

Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>

Seemed "obviously good" anti-oops medicine to me, then I double
checked against some code that is AFAIK still correct..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/