Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr) function

[Jesse Barnes]

On Sunday, September 28, 2008 4:36 pm Arjan van de Ven wrote:
> The patch below introduces a pci_ioremap() function that should make it
> easier for driver authors to do the right thing for the simple, common
> case.
>
> There's also 18 patches that introduce users of this; to reduce lkml noise
> I've only stuck them in a git tree at
> git://git.kernel.org/pub/scm/linux/kernel/git/arjan/linux-2.6-pci_ioremap.g
>it
> (http://git.kernel.org/?p=linux/kernel/git/arjan/linux-2.6-pci_ioremap.git;
>a=summary)
>
>
> From fef1dd836bc7dc07962a0ae4019af9efd373c76f Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> Date: Fri, 26 Sep 2008 16:34:52 -0700
> Subject: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr) function
>
> A common thing in many PCI drivers is to ioremap() an entire bar.
> This is a slightly fragile thing right now, needing both an address and a
> size, and many driver writers do.. various things there.
>
> This patch introduces an pci_ioremap() function taking just a PCI device
> struct and the bar number as arguments, and figures this all out itself, in
> one place. In addition, we can add various sanity checks to this function
> (the patch already checks to make sure that the bar in question really is a
> MEM bar; few to no drivers do that sort of thing).
>
> Hopefully with this type of API we get less chance of mistakes in drivers
> with ioremap() operations.
>
> Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>

Applied to my linux-next branch, thanks.  I assume you'll have Linus pull the 
driver updates later?

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/