Re: [PATCH -tip] drivers/serial/8250.c: 'i' may be useduninitialized

From: Alan Cox
Date: Wed Oct 01 2008 - 06:34:31 EST


On Wed, 1 Oct 2008 10:01:50 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

>
> ( Alan Cc:-ed. Seems like gcc bogosity - so your solution of using
> uninitialized_var() is the correct way to annotate this. )

Sorry but uninitialized_var() is too ugly to be acceptable. Please use a
proper __foo style notation for consistency with the rest of the kernel

(Besides which last time I checked current gcc could figure that one out)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/