RE: [patch 1/2] x86: track memtype for RAM in page struct

[Pallipadi, Venkatesh]

>-----Original Message-----
>From: Ingo Molnar [mailto:mingo@xxxxxxx]
>Sent: Sunday, September 14, 2008 7:13 AM
>To: Pallipadi, Venkatesh
>Cc: arjan@xxxxxxxxxxxxxxx; tglx@xxxxxxxxxxxxx; hpa@xxxxxxxxx;
>andi@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Siddha,
>Suresh B; Arjan van de Ven
>Subject: Re: [patch 1/2] x86: track memtype for RAM in page struct
>
>
>* Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx> wrote:
>
>> From: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>
>> Subject: [patch 1/2] x86: track memtype for RAM in page struct
>>
>> Track the memtype for RAM pages in page struct instead of using the
>> memtype list. This avoids the explosion in the number of entries in
>> memtype list (of the order of 20,000 with AGP) and makes the PAT
>> tracking simpler. We are using PG_arch_1 bit in page->flags.
>
>this is in contradiction to this comment:
>
>>  /*
>> + * RED-PEN:  TODO: Add PageReserved() check aswell here,
>> + * once we add SetPageReserved() to all the drivers using
>> + * set_memory_* or set_pages_*
>
>if it's marked PG_arch_1, why is there any need for PageReserved?
>

Marking PageReserved will take care of all the places where Reserved is being checked,
like swap etc. And we don't have to add checks for extra bit in architecture independent
code.

Thanks,
Venki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/