Re: [PATCH] Introduce new LSM hooks where vfsmount is available.

From: James Morris
Date: Tue Sep 23 2008 - 17:20:42 EST


On Tue, 23 Sep 2008, Alexey Dobriyan wrote:

> > > > I don't see any technical errors in this patch.
> > > >
> > > > If it is going to be merged, please make a new config option for
> > > > path-based hooks (similar to that for the network hooks), so they can be
> > > > compiled out.
>
> Another pointless config option.

Why is it pointless? If distros don't want to use these hooks, they
shouldn't have to have them enabled.

>
> It's actually pretty surprising that SECURITY_NETWORK is
> a) user-visible and b) is not SECURITY && NET.
>
> Same for SECURITY_NETWORK_XFRM.

IIRC, this option was a perquisite for merge. Networking hooks have a
relatively high overhead and not everyone wants to use them, even if they
have networking enabled.


- James
--
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/