Re: [PATCH 3/4][resubmit] TPM: rcu locking

[Jonathan Corbet]

On Tue, 23 Sep 2008 17:19:33 -0300
Rajiv Andrade <srajiv@xxxxxxxxxxxxxxxxxx> wrote:

> Protects tpm_chip_list when transversing it.

It all looks like it should work (though it might make sense to include
<linux/rcupdate.h> and <linux/rculist.h>.  But I have to ask: do you
really need the added complexity of RCU here?  I suspect that TPM
devices don't come and go very often...once most of us have ripped it
out, we tend to leave it out...:)

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/