Re: [patch] sched: trivial fix for incorrect comments

From: Chris Friesen
Date: Tue Sep 23 2008 - 12:08:24 EST


Ingo Molnar wrote:
* Chris Friesen <cfriesen@xxxxxxxxxx> wrote:

From: Chris Friesen <cfriesen@xxxxxxxxxx>

A couple of the comments for the conditional definitions in sched.c are
incorrect. Here's a trivial patch fixing them up.

looks good to me, but the patch is whitespace corrupted. Please see Documentation/email-clients.txt about how to send plain-text patches.

Ingo


Actually, I thought I was following the procedures in there. It turns out that older Thunderbird requires an external editor, disabling format=flowed, and a line wrap of 0. The email clients doc makes it sound
like if you use an external editor you don't need the other parts. With
current Thunderbird the external editor is still not sufficient by itself,
but isn't required if the other two items are configured properly.

Here's another try.

---
From: Chris Friesen <cfriesen@xxxxxxxxxx>
Subject: [PATCH] sched: trivial fix for incorrect comments

A couple of the comments for the conditional definitions in sched.c are
incorrect. Here's a trivial patch fixing them up.

Signed-off-by: Chris Friesen <cfriesen@xxxxxxxxxx>
Approval token "Nortel-02-July-2008-01"
---
kernel/sched.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index cc1f81b..8ddca50 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -298,9 +298,9 @@ static DEFINE_PER_CPU(struct cfs_rq, init_cfs_rq) ____cacheline_aligned_in_smp;
static DEFINE_PER_CPU(struct sched_rt_entity, init_sched_rt_entity);
static DEFINE_PER_CPU(struct rt_rq, init_rt_rq) ____cacheline_aligned_in_smp;
#endif /* CONFIG_RT_GROUP_SCHED */
-#else /* !CONFIG_FAIR_GROUP_SCHED */
+#else /* !CONFIG_USER_SCHED */
#define root_task_group init_task_group
-#endif /* CONFIG_FAIR_GROUP_SCHED */
+#endif /* CONFIG_USER_SCHED */

/* task_group_lock serializes add/remove of task groups and also changes to
* a task group's cpu shares.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/