Re: [patch] x86, ptrace: void dopiness

From: Ingo Molnar
Date: Tue Sep 23 2008 - 07:48:53 EST



* Metzger, Markus T <markus.t.metzger@xxxxxxxxx> wrote:

> >-----Original Message-----
> >From: Ingo Molnar [mailto:mingo@xxxxxxx]
> >Sent: Montag, 22. September 2008 14:08
> >To: Metzger, Markus T
>
> >> The void-cast is intentional in both cases.
> >>
> >> I thought it a question of style, i.e. that we don't want void casts
> >> just like we want NULL instead of 0.
> >
> >ok.
> >
> >But you could mark ds_release_bts() as a __must_check
> >function, in that
> >case the (void) has functional aspects as well: the kernel build will
> >complain if a return value is ignored unintentionally.
>
> Wouldn't every non-void function be __must_check?

no, only those which we mark so explicitly.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/