Re: [PATCH 4/4] x86: Add sysfs entries for UV

[Ingo Molnar]

* Russ Anderson <rja@xxxxxxx> wrote:

> +struct kobject *sgi_uv_kobj;

should be static?

> +static int __init sgi_uv_sysfs_init(void)
> +{
> +	if (!sgi_uv_kobj)
> +		sgi_uv_kobj = kobject_create_and_add("sgi_uv", firmware_kobj);
> +	if (!sgi_uv_kobj) {
> +		printk(KERN_WARNING "kobject_create_and_add sgi_uv failed \n");
> +		return -EINVAL;
> +	}
> +
> +	sysfs_create_file(sgi_uv_kobj, &partition_id_attr.attr);
> +	sysfs_create_file(sgi_uv_kobj, &coherence_id_attr.attr);

missing checks for failure?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/