Re: [Linux-fbdev-devel] [PATCH] fbdev: don't allow to set a videomode via vga= if FB doesn't support it

[Andrew Morton]

On Mon, 22 Sep 2008 22:32:40 +0200
"Michal Januszewski" <michalj@xxxxxxxxx> wrote:

> On Mon, Sep 22, 2008 at 22:00, Bruno Pr__mont <bonbons@xxxxxxxxxxxxxxxxx> wrote:
> 
> > This looks pretty much the same as what I requested some time ago:
> >
> > http://bugzilla.kernel.org/show_bug.cgi?id=8062
> >
> > Would need to check -mm archives for the actual patch.
> >
> > Don't remember why it did not make it to mainline...
> 
> Well, the bug and the mm fix [1] are about a similar, yet slightly different
> issue than the one I'm trying to fix with my patch (note that the issue
> reported in the bug is currently fixed in the kernel, but the actual fix
> is differrent than the one in -mm due to x86 boot code refactoring
> that took place since then).
> 
> My patch fixes the case where the framebuffer is enabled, but none of
> the drivers support boot-time video mode setting, whereas the old
> patch fixed the case where it was possible to set a video mode even
> though the kernel didn't contain the framebuffer layer.
> 
> [1] http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc2/2.6.21-rc2-mm1/broken-out/fbdev-ignore-vesa-modes-if-framebuffer-is-disabled.patch
> 

OK.  It was merged into mainline but was later reverted by Linus:


commit 01e73be3c8f254ef19d787f9b6757468175267eb
Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Date:   Tue May 8 20:12:30 2007 -0700

    Revert "fbdev: ignore VESA modes if framebuffer is disabled"
    
    This reverts commit 464bdd33e9baad9806c7adbd8dfc37081a55f27e.
    
    Peter Anvin correctly points out that VESA modes have nothing to do with
    frame buffers per se - they are often just regular extended text modes.
    Disabling them just because we don't have frame buffer support is very
    wrong.
    
    Cc: H. Peter Anvin <hpa@xxxxxxxxx>
    Cc: Antonino A. Daplas <adaplas@xxxxxxxxx>,
    Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/