Re: [PATCH] AMD IOMMU: revert "x86, AMD IOMMU: honor iommu=offinstead of amd_iommu=off"

[FUJITA Tomonori]

On Mon, 22 Sep 2008 18:31:09 +0200
Joerg Roedel <joerg.roedel@xxxxxxx> wrote:

> On Tue, Sep 23, 2008 at 12:25:23AM +0900, FUJITA Tomonori wrote:
> > I don't think that users need to have iommu=calgary parameter to use
> > calgary IOMMU by default. If you enable CONFIG_CALGARY_IOMMU,
> > CALGARY_IOMMU_ENABLED_BY_DEFAULT is also enabled by default. If a
> > kernel finds calgary IOMMU, the kernel uses it by default.
> > 
> > It's also consistent with how SWIOTLB. Users don't need iommu=soft
> > parameter to enable SWIOTLB. A kernel enables SWIOTLB automatically
> > when necessary.
> 
> Yes. The parameters are usefull if a user wants to enable a specific
> IOMMU implementation. The user could be an IOMMU developer testing
> changes in a special implementation the kernel would not choose by
> default on his machine.
> I like Ingo's idea here. Lets do boths, implementing iommu=$type to
> force a specific iommu implementation and $(type)_iommu=off to disable
> one.

This is exactly what I've been against, something like "I like it and
let do it".

Sure, Ingo's suggestion looks consistent, but these parameters
interact other parameters. If we are serious about improving the IOMMU
parameters, we need to spend more time to think about the final
picture of all the IOMMU parameters that we need.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/