Re: [ath9k-devel] ath9k: massive unexplained latency in 2.6.27 (rc5, rc6, probably others)

From: Steven Noonan
Date: Mon Sep 22 2008 - 11:11:49 EST


On Mon, Sep 22, 2008 at 1:06 AM, Luis R. Rodriguez
<lrodriguez@xxxxxxxxxxx> wrote:
> Please test the following patch.
>
> diff --git a/drivers/net/wireless/ath9k/core.c b/drivers/net/wireless/ath9k/core.c
> index c262ef2..9a51739 100644
> --- a/drivers/net/wireless/ath9k/core.c
> +++ b/drivers/net/wireless/ath9k/core.c
> @@ -681,10 +681,12 @@ int ath_open(struct ath_softc *sc, struct ath9k_channel *initial_chan)
> * Enable MIB interrupts when there are hardware phy counters.
> * Note we only do this (at the moment) for station mode.
> */
> +#if 0
> if (ath9k_hw_phycounters(ah) &&
> ((sc->sc_ah->ah_opmode == ATH9K_M_STA) ||
> (sc->sc_ah->ah_opmode == ATH9K_M_IBSS)))
> sc->sc_imask |= ATH9K_INT_MIB;
> +#endif
> /*
> * Some hardware processes the TIM IE and fires an
> * interrupt when the TIM bit is set. For hardware
>

It didn't apply to -rc7, but I managed to apply it manually
(apparently you made this for wireless-testing?) and added the #if 0.
After 7 hours uptime with the driver, no apparent interrupt storm.

I'll do more thorough testing later, but I have a 3 hour drive today,
and some packing to do, so it'll need to wait a bit.

- Steven
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/