Re: [patch] x86, ptrace: void dopiness

[Ingo Molnar]

* Markus Metzger <markus.t.metzger@xxxxxxxxx> wrote:

> +++ gits.x86/arch/x86/kernel/ptrace.c	2008-09-19 13:53:02.%N +0200
> @@ -738,7 +738,7 @@
>  		unsigned int sig = 0;
>  
>  		/* we ignore the error in case we were not tracing child */
> -		(void)ds_release_bts(child);
> +		ds_release_bts(child);

hm, here the cast is OK because we actually ignore the return value.

> @@ -947,7 +947,7 @@
>  	clear_tsk_thread_flag(child, TIF_SYSCALL_EMU);
>  #endif
>  #ifdef CONFIG_X86_PTRACE_BTS
> -	(void)ds_release_bts(child);
> +	ds_release_bts(child);

is it right/intentional here?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/