Re: [PATCH] debug: Introduce a dev_WARN() function

[Greg KH]

On Fri, Sep 19, 2008 at 09:07:33PM -0700, Arjan van de Ven wrote:
> 
> From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> Date: Fri, 19 Sep 2008 21:03:06 -0700
> Subject: [PATCH] debug: Introduce a dev_WARN() function
> 
> in the line of dev_printk(), this patch introduces a dev_WARN() macro,
> that takes a struct device and then a printk format/args set of arguments.
> Unlike dev_printk(), the effect is that of WARN() in that a full warning
> message (including filename/line, module list, versions and a backtrace)
> is printed in addition to the device name and the arguments.

I like the idea, but we already have dev_warn(), so dev_WARN() might be
a bit confusing for people.

Perhaps just documenting it with a docbook tag would suffice?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/