Re: [PATCH] remove fullflush and nofullflush in IOMMU generic option

[Joerg Roedel]

On Sat, Sep 20, 2008 at 03:40:32AM +0900, FUJITA Tomonori wrote:
> On Fri, 19 Sep 2008 19:46:05 +0200
> Joerg Roedel <joerg.roedel@xxxxxxx> wrote:
> 
> > On Sat, Sep 20, 2008 at 02:34:15AM +0900, FUJITA Tomonori wrote:
> > > > You keep this option for AMD IOMMU too. If you move it to AMD IOMMU code
> > > > then you can remove nofullflush there.
> > > 
> > > I'm not sure what you mean. You think that we can't change the
> > > exported option, how can we remove nofullflush option?
> > 
> > You can keep it for GART. But as I already wrote its ok to remove it for
> > AMD IOMMU.
> 
> My patch doesn't add nofullflush option to AMD IOMMU. So we don't
> remove to it.
> 
> If my patch adds it to AMD IOMMU, it's a bug.

Ah ok, true. I looked at the wrong portion of the patch. Sorry.

Joerg

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/