Re: [PATCH] x86: c1e_idle: don't mark TSC unstable if CPU hasinvariant TSC

From: Thomas Gleixner
Date: Fri Sep 19 2008 - 14:21:54 EST


On Fri, 19 Sep 2008, Andreas Herrmann wrote:
> TSC on K8 is not P-state and C-state invariant.
> Thus on K8 you'll have a TSC drift if C1E is entered.
>
> This means that if C1E is enabled TSC should be marked unstable on
> those CPUs (it shouldn't be used as a clocksource).

Correct. I missed that detail with the newer CPUs when I did the C1E
idle stuff. Thanks for catching it. I'll schedule it for Linus when
I'm back from Portland.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/